Wr/refactor @W-20812411@ #296
Open
+322
−564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillieRuemmele
force-pushed
the
wr/refactor
branch
from
8826f83 to
46f5100
Compare
WillieRuemmele
force-pushed
the
wr/refactor
branch
from
2a92d83 to
ea7516e
Compare
WillieRuemmele
force-pushed
the
wr/refactor
branch
from
f8ddec7 to
d32418e
Compare
shetzel
approved these changes
Jan 20, 2026
test/nuts/shared-setup.ts
Outdated
| const isWindows = process.platform === 'win32'; | ||
| const waitTime = isWindows ? 10 * 60 * 1000 : 5 * 60 * 1000; // 10 minutes on Windows, 5 minutes otherwise | ||
| console.log(`waiting ${waitTime / 1000 / 60} minutes for org to be ready (platform: ${process.platform})`); | ||
| await sleep(waitTime); |
Contributor
There was a problem hiding this comment.
Rather than a hard wait time of 5 or 10 minutes, I'd rather have a threshold where we stop trying to do the setup. This will allow faster test runs. I think we can keep this for now, but if it causes a problem we should revisit this strategy.
| execCmd<AgentPublishAuthoringBundleResult>( | ||
| `agent publish authoring-bundle --api-name ${invalidApiName} --target-org ${getUsername()} --json`, | ||
| { ensureExitCode: 1 } | ||
| { ensureExitCode: 2 } |
Contributor
There was a problem hiding this comment.
Do we know why this is returning 2?
Contributor
Author
There was a problem hiding this comment.
we call this.error(errormessage) in the command, which has an exit code 2...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What issues does this PR fix or reference?
consumes forcedotcom/agents#202
@W-20812411@